Fix frontmatter property spaces#96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43.
This fixes text editing in the live preview Properties/frontmatter panel so trailing spaces are not immediately stripped while the user is typing. The root cause was that
serializeFrontmatterRawtrimmed string values on every keystroke; because the panel is controlled by the serialized frontmatter, typing a space at the end of a property value was instantly normalized away.The serializer now preserves string values during editing, still drops values that are empty after trimming, and quotes YAML values when leading or trailing whitespace must be preserved.
Validation
npm test -- --run src/features/editor/FrontmatterPanel.helpers.test.ts src/features/editor/Editor.test.tsx --testNamePattern "allows inserting spaces|properties|Frontmatter helpers"npm run lint -- src/features/editor/FrontmatterPanel.tsx src/features/editor/FrontmatterPanel.helpers.test.ts src/features/editor/Editor.test.tsx