feat: update code to work with ruby-lsp-0.17.1#11
feat: update code to work with ruby-lsp-0.17.1#11aaronlifton wants to merge 1 commit intojscharf:mainfrom
Conversation
- Update formatter runner to implement RubyLsp::Requests::Support::Formatter interface, implementing `run_formatting` - Update to register addon with global state, similar to the Rubocop formatter in `ruby-lsp` - This allows the addon to work with version 0.17.1 of ruby-lsp
|
just tried setting this up, and vscode shows me the following error:
# Gemfile
gem 'ruby-lsp-rubyfmt', :git => 'https://github.com/aaronlifton/ruby-lsp-rubyfmt.git', :branch => 'main' |
|
@jscharf , any change to get this merged? |
|
@cirdes I would love to get this merged! One of my problems is that I've been away from this type of work for a while so I need to come up testing steps so I can test this locally before merging. I will try to get to this but any context you or others can help provide to get me caught up on what's changed in Ruby LSP integrations in the last year or so would be a big help. |
|
I'm also not terribly familiar with
gem "ruby-lsp-rubyfmt", git: "https://github.com/jscharf/ruby-lsp-rubyfmt", ref: "cb26b5285bf254426d409148ae4ec22134aca324"
{
"[ruby]": {
"editor.defaultFormatter": "Shopify.ruby-lsp",
"editor.formatOnSave": true
},
"rubyLsp.formatter": "rubyfmt",
}
|

run_formattingruby-lsp