Skip to content

fix(search): guard exercise cells to prevent execution errors#291

Merged
jsboige merged 2 commits intomainfrom
feature/search-notebooks-verify-2026
Apr 19, 2026
Merged

fix(search): guard exercise cells to prevent execution errors#291
jsboige merged 2 commits intomainfrom
feature/search-notebooks-verify-2026

Conversation

@jsboige
Copy link
Copy Markdown
Owner

@jsboige jsboige commented Apr 19, 2026

Summary

  • Guard exercise cells in Search-1 and Search-8 that caused execution failures during Run All
  • Search-1: wrap bfs_solve(mc) and visualize_maze(maze, solution) in try/except to handle NameError when students haven't completed the MissionariesCannibals class
  • Search-8: comment out raise NotImplementedError("A completer") stub that blocked full notebook execution

Test plan

  • All 11 Search notebooks executed successfully (11/11 PASS) via notebook_tools.py execute
  • Execution times: 6.4s (Search-1) to 47.2s (Search-11)
  • 21 TODO exercises + 10 guided exercises = 31 total across all notebooks
  • Verified students can now Run All without errors even with incomplete exercises

Context

Preparation for EPITA TP Exploration (Search) on Monday 20/04 morning.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

jsboige and others added 2 commits April 19, 2026 12:28
Search-1: Wrap bfs_solve(mc) and visualize_maze() in try/except to
handle NameError/NotImplementedError when exercises are incomplete.
Search-8: Comment out raise NotImplementedError in exercise 1 stub
to allow full notebook execution without student code.

Ensures all 11 Search notebooks pass automated execution for EPITA TP.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Clear outputs and execution_count from 43 exercise cells in 17 notebooks
(Part1-Foundations, Part2-CSP, Applications). Exercise cells should have
no pre-filled outputs to prevent execution errors and keep solutions empty
for students.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Owner Author

@jsboige jsboige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ClusterManager — LGTM. Nettoyage correct des outputs des cellules exercices dans les notebooks Search (execution_count: null + outputs supprimés). Prévient la divulgation des solutions aux étudiants. Approche standard pour les notebooks pédagogiques. ✅

@jsboige jsboige merged commit b7dd0d0 into main Apr 19, 2026
1 check passed
@jsboige jsboige deleted the feature/search-notebooks-verify-2026 branch April 19, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant