Repository navigation
Rework how keys are represented, named, and bound - #8
Merged
Merged
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
requested review from
aaronpk,
c2bo,
jricher and
paulbastian
as code owners
July 27, 2026 22:56
jricher
reviewed
Jul 27, 2026
jricher
reviewed
Jul 27, 2026
jricher
approved these changes
Jul 27, 2026
jricher
left a comment
jricher
left a comment
Owner
There was a problem hiding this comment.
One wording note to call out parallelism between methods but otherwise I think this is really good work.
Co-authored-by: Justin Richer <github@justin.richer.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep each binding method within one algorithm registry. A pre-registered key is a JWK naming a fully specified JWS algorithm. A runtime key names an "HTTP Signature Algorithms" value in
alg.Replace the runtime key per-algorithm parameters with a single
pubsignature parameter, defined for ECDSA, Ed25519 and ML-DSA. The bound key MUST be asymmetric.Select a pre-registered key with keyid rather than a pinned httpsig_bound_access_token_kid, so that rotation needs no registration change.
The RS takes the key from the token binding, using cnf.jwk or a new HTTP Signature Key (htsk) confirmation method.
Rendered | diff