Repository navigation
Inline key presentation - #2
Merged
Merged
Conversation
jricher
commented
Jul 25, 2026
jricher
commented
Owner
- fix lint
- Extract generatable examples into include files
- Add --runtime-key to embed public key as signature parameters
- Add example regeneration script and regenerate examples
- Update verification examples.
- clean up validation section
c2bo
reviewed
Jul 25, 2026
c2bo
left a comment
c2bo
left a comment
Collaborator
There was a problem hiding this comment.
I believe there is some confusion with kid vs keyid, although i am not sure i got everything right with the proposed changes.
paulbastian
reviewed
Jul 25, 2026
paulbastian
reviewed
Jul 25, 2026
Comment on lines
+110
to
+111
| * Present its public key in the as described in {{embed-keys}}. | ||
| * Include the `kid` signature parameter uniquely identifying the key. |
Collaborator
There was a problem hiding this comment.
I think the draft text should mandate that only either of them MUST be present
Co-authored-by: Christian Bormann <chris.bormann@gmx.de>
panva
approved these changes
Jul 27, 2026
Co-authored-by: Christian Bormann <chris.bormann@gmx.de> Co-authored-by: Paul Bastian <paul.bastian@posteo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.