Skip to content

fix(sso): force-fetch the upstream tag in apply.sh - #4

Merged
jplorier merged 1 commit into
mainfrom
fix/apply-force-fetch-tag
Oct 29, 2026
Merged

jplorier merged 1 commit into
mainfrom
fix/apply-force-fetch-tag

Conversation

@jplorier

Copy link
Copy Markdown
Owner

The image build for #2 failed before applying the overlay:

[sso] fetching tag @hyperdx/app@2.42.0
 ! [rejected] @hyperdx/app@2.42.0 -> @hyperdx/app@2.42.0  (would clobber existing tag)

The CI checkout (fetch-depth: 0) copies every tag the fork holds, and at build time the fork held a @hyperdx/app@2.42.0 tag. apply.sh fetched the upstream tag without +, so git refused to overwrite it. No roles image was produced, and the cluster still runs 2.39.1-sso.da9df32.

Fix: fetch +refs/tags/${TAG}:refs/tags/${TAG} so upstream's tag always wins.

Tested: in a local clone with the tag pointed at the wrong commit, the old command reproduces the exact CI error, and the new one updates the tag to upstream's cf00ae53f. bash -n passes.

After merge, the push-triggered build uses the workflow default (2.42.0). A 2.39.1 build (workflow_dispatch) is the one to deploy first, since it matches chart 3.4.0.

The CI checkout of the fork (fetch-depth 0) copies every tag the fork holds. If one matches the upstream tag being built, the non-forced fetch refuses with "would clobber existing tag" and the build dies before the overlay is applied: the build for #2 failed this way on @hyperdx/app@2.42.0. Fetch with + so upstream's tag always wins.
@jplorier
jplorier merged commit 8e1da11 into main Oct 29, 2026
@jplorier
jplorier deleted the fix/apply-force-fetch-tag branch October 29, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant