Repository navigation
fix(sso): force-fetch the upstream tag in apply.sh - #4
Merged
Merged
Conversation
The CI checkout of the fork (fetch-depth 0) copies every tag the fork holds. If one matches the upstream tag being built, the non-forced fetch refuses with "would clobber existing tag" and the build dies before the overlay is applied: the build for #2 failed this way on @hyperdx/app@2.42.0. Fetch with + so upstream's tag always wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image build for #2 failed before applying the overlay:
The CI checkout (
fetch-depth: 0) copies every tag the fork holds, and at build time the fork held a@hyperdx/app@2.42.0tag.apply.shfetched the upstream tag without+, so git refused to overwrite it. No roles image was produced, and the cluster still runs2.39.1-sso.da9df32.Fix: fetch
+refs/tags/${TAG}:refs/tags/${TAG}so upstream's tag always wins.Tested: in a local clone with the tag pointed at the wrong commit, the old command reproduces the exact CI error, and the new one updates the tag to upstream's
cf00ae53f.bash -npasses.After merge, the push-triggered build uses the workflow default (2.42.0). A 2.39.1 build (
workflow_dispatch) is the one to deploy first, since it matches chart 3.4.0.