Skip to content

DEV-6802 Add FIND, SEARCH, and ISERROR functions - #13

Merged
benkleintechnologies merged 5 commits into
joshimi:masterfrom
benkleintechnologies:master
Feb 10, 2026
Merged

benkleintechnologies merged 5 commits into
joshimi:masterfrom
benkleintechnologies:master

Conversation

@benkleintechnologies

Copy link
Copy Markdown
Collaborator

No description provided.

@ben-schreiber ben-schreiber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I think you should also go through the PR and write a review for yourself from the perspective of a reviewer and not the author

Comment thread src/calculate/operation/string.rs Outdated
Comment thread tests/common/mod.rs Outdated
Comment thread src/calculate/operation/string.rs Outdated
Comment thread src/calculate/operation/string.rs Outdated
Comment thread src/calculate/operation/string.rs
@benkleintechnologies

Copy link
Copy Markdown
Collaborator Author

I went through the PR and don't have any more comments for myself after my changes, but it's hard to review myself. I try to do that before I commit

Comment thread src/calculate/operation/function.rs Outdated
Comment thread src/calculate/operation/function.rs
Comment thread src/calculate/operation/function.rs Outdated
@benkleintechnologies
benkleintechnologies merged commit 8d7b2b8 into joshimi:master Feb 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants