Use External ZOFU if present#34
Open
kprussing wants to merge 4 commits into
Open
Conversation
If the user has an installation of ZOFU, we should try to use that instead of rebuilding. This reduces the compilation phase to make it easier on those who need to build the tests.
The FindZOFU.cmake from the ZOFU package expects the module path to be set. This is not a transient property of the library, and, therefore, we must add the module directory to our target include lists.
The ZOFU library does not install its find_package implementation. Instead, we need to include a copy to probe the system for the library. This should be removed if ZOFU starts to distribute its find_package script as a standard.
The comments about usage have changed. We are now distributing the find_package script which is the item that should be deprecated.
Contributor
Author
|
This is probably not a perfect solution. ZOFU itself does not install its find_package script so I had to include a duplicate. However, the find_package script can report false positives. It may be worth while to update ZOFU's cmake system, but that is a separate topic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user may have a copy of ZOFU installed in a known location. This change set allows the user to specify ZOFU's installation details according to its
find_packagescript and it will respect that. A copy of the find_package script is included for general usability since ZOFU does not install itsfind_pacakgescript by default. This will fall back to fetching and building ZOFU if the user specified library is not available.Closes #31