Repository navigation
Fix PingPong layout and camera recovery on landscape phones - #2
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Horizontal phones previously stacked the camera below the score, retained the setup form's scroll position when starting a match, and paused on rotation without clearing calibration. The live view and score now sit side by side on short landscape screens, with pause/resume above both panels and secondary actions scrolling inside each panel. Long names fit the compact scoreboard, and dialogs respect viewport and safe-area limits.
Starting another screen resets page scroll. Both orientation APIs and changes to captured video dimensions now invalidate calibration, pause tracking and allow successful recalibration while retaining points. The video and calibration overlay share the same aspect ratio.
Validation: production build, formatting, lint, TypeScript and 18 unit tests pass. 41 browser tests pass across desktop, portrait and two landscape Chromium viewports (844×390 and 568×320), plus landscape WebKit. Tests cover synthetic camera calibration, rotation and frame-size changes, retained scores, pause/resume, detector controls, short dialogs, assisted point confirmation and the existing complete game flow. Physical camera/device and real-game accuracy checks remain pending.