Repository navigation
ci: run the go checks on the release PR - #51
Merged
Merged
Conversation
Pull requests opened with the Actions token start no workflows, so the release PR never got the go checks and would be blocked once they are required. After changesets/action opens or updates the PR, release.yml now starts go.yml on changeset-release/main with a workflow_dispatch, the one event the Actions token is allowed to trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for requiring the
gochecks onmainwith branch protection.Problem
The release workflow opens its
chore: releasePR with the Actions token, and events from that token start no workflows. So the release PR never getscheckorintegration. Once those are required, every release PR would be blocked.Fix
go.ymlalso triggers onworkflow_dispatch.release.yml, afterchangesets/actionopens or updates the PR (it outputspr-number), runsgh workflow run go.yml --ref changeset-release/main.workflow_dispatchis the documented exception: the Actions token can trigger it. The check runs land on the release branch's head commit, so they show on the PR under the same names a required-check rule matches (check,integration). The job gainsactions: writefor this.The PR-only
imagejob is skipped on a dispatch run, so it shouldn't be one of the required checks.Testing
The new step only runs on
mainafter changesets land, so this PR can't exercise it. The YAML parses, and thegoworkflow still runs normally on this PR. Its first real run is the next release PR, wherecheckandintegrationshould appear within a minute of the PR being updated.CI only, so no changeset.