Skip to content

ci: run the go checks on the release PR - #51

Merged
jordan-simonovski merged 1 commit into
mainfrom
ci/run-checks-on-release-pr
Nov 14, 2026
Merged

jordan-simonovski merged 1 commit into
mainfrom
ci/run-checks-on-release-pr

Conversation

@jordan-simonovski

Copy link
Copy Markdown
Owner

Prerequisite for requiring the go checks on main with branch protection.

Problem

The release workflow opens its chore: release PR with the Actions token, and events from that token start no workflows. So the release PR never gets check or integration. Once those are required, every release PR would be blocked.

Fix

  • go.yml also triggers on workflow_dispatch.
  • release.yml, after changesets/action opens or updates the PR (it outputs pr-number), runs gh workflow run go.yml --ref changeset-release/main. workflow_dispatch is the documented exception: the Actions token can trigger it. The check runs land on the release branch's head commit, so they show on the PR under the same names a required-check rule matches (check, integration). The job gains actions: write for this.
  • No personal access token or GitHub App needed.

The PR-only image job is skipped on a dispatch run, so it shouldn't be one of the required checks.

Testing

The new step only runs on main after changesets land, so this PR can't exercise it. The YAML parses, and the go workflow still runs normally on this PR. Its first real run is the next release PR, where check and integration should appear within a minute of the PR being updated.

CI only, so no changeset.

Pull requests opened with the Actions token start no workflows, so the
release PR never got the go checks and would be blocked once they are
required. After changesets/action opens or updates the PR, release.yml now
starts go.yml on changeset-release/main with a workflow_dispatch, the one
event the Actions token is allowed to trigger.
@jordan-simonovski
jordan-simonovski merged commit 5999d5c into main Nov 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant