Skip to content

fix: release-check passes when no changesets are pending - #49

Merged
jordan-simonovski merged 1 commit into
mainfrom
fix/release-check-no-changesets
Nov 14, 2026
Merged

jordan-simonovski merged 1 commit into
mainfrom
fix/release-check-no-changesets

Conversation

@jordan-simonovski

Copy link
Copy Markdown
Owner

Fixes the release-check job added in #46, which fails on every pull request that has no changeset (for example #48).

Cause

With nothing to release, Changesets v3's changeset version prints "No unreleased changesets found." and exits 1. npm run release runs it under bash -e, so the job failed before reaching its own logic. I'd only tested #46 with changesets pending.

Fix

Skip the dry-run when no changesets are pending; there's nothing for a release to do.

Checked locally

CI only, so no changeset and no multi-agent review. Once this merges, #48 needs its checks re-run against the new main; I'll rebase it.

Changesets v3's changeset version exits 1 with 'No unreleased changesets
found', so the dry-run failed on every pull request without a changeset.
Skip the dry-run when there is nothing to release.
@jordan-simonovski
jordan-simonovski merged commit 7ae6d82 into main Nov 14, 2026
4 checks passed
@jordan-simonovski
jordan-simonovski deleted the fix/release-check-no-changesets branch November 14, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant