Repository navigation
fix: release-check passes when no changesets are pending - #49
Merged
Merged
Conversation
Changesets v3's changeset version exits 1 with 'No unreleased changesets found', so the dry-run failed on every pull request without a changeset. Skip the dry-run when there is nothing to release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
release-checkjob added in #46, which fails on every pull request that has no changeset (for example #48).Cause
With nothing to release, Changesets v3's
changeset versionprints "No unreleased changesets found." and exits 1.npm run releaseruns it underbash -e, so the job failed before reaching its own logic. I'd only tested #46 with changesets pending.Fix
Skip the dry-run when no changesets are pending; there's nothing for a release to do.
Checked locally
main): "No pending changesets; nothing to dry-run.", exit 0.CI only, so no changeset and no multi-agent review. Once this merges, #48 needs its checks re-run against the new
main; I'll rebase it.