fix: spread options in fillLetters toRegex path so capture works for letters - #23
Open
Diwak4r wants to merge 1 commit into
Open
fix: spread options in fillLetters toRegex path so capture works for letters#23Diwak4r wants to merge 1 commit into
Diwak4r wants to merge 1 commit into
Conversation
…letters fillLetters nested 'options' instead of spreading it when building a toRegex string with step > 1, so the capture flag was silently dropped for the alpha path (it returned 'a|c|e' instead of '(a|c|e)'). The numbers path already spreads correctly. Mirror that behavior and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fillwithtoRegex: true,capture: true, andstep > 1returns an ungrouped alternation for letters (a|c|e) but a correctly grouped one for numbers ((1|3|5)).Root cause: in
fillLetters, thetoRegexcall nested the options object instead of spreading it:So
capture(and every other option) was dropped on the alpha path. The numbers path already spreads ({ wrap: false, ...options }).Fix
Spread the options to match
fillNumbers:Test plan
fill('a','z',2,{toRegex:true,capture:true})==='(a|c|e|g|i|k|m|o|q|s|u|w|y)'.npx mocha→ 68 passing.Before fix the new test fails (
'a|c|e...' == '(a|c|e...)'); after fix it passes.