Remove unused VITE_APP_MODE environment variable - #58
Merged
Conversation
VITE_APP_MODE was set in dev:prod script and test mocks but never read by any application code. Removed from all three locations. Docs updated to drop the vestigial-variable entry. Doc-consolidation audit item checked off (SYNC_SCENARIOS* files were already in docs/). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015e47SEwm82N6DWrJBXJPTq
✅ Deploy Preview for savrdev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the vestigial
VITE_APP_MODEenvironment variable that was set by build scripts and test mocks but never actually used by the application code. Debug behavior is now controlled exclusively by theVITE_DEBUGvariable.Changes
VITE_APP_MODEfrompackage.jsondev:prodscript (now runs standardvite dev)VITE_APP_MODEmock from Jest test setup (lib/__tests__/setup.js)VITE_APP_MODEmock from environment test mocks (lib/__tests__/__mocks__/environment.js)Details
The
VITE_APP_MODEvariable was previously set in development and test configurations but was never referenced bysrc/config/environment.tsor any application code. This cleanup simplifies the build configuration and reduces unnecessary environment variable management while maintaining all existing functionality through theVITE_DEBUGflag.https://claude.ai/code/session_015e47SEwm82N6DWrJBXJPTq