Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GitHub Actions workflow for testing with a running Kodi instance and removes the existing Python package workflow. The changes shift from a Windows-based multi-version testing approach to a simpler Ubuntu-based workflow that runs Kodi in a headless environment.
- Replaces complex Windows-based workflow with simpler Ubuntu workflow
- Adds Kodi installation and execution in headless mode using xvfb
- Maintains test execution and artifact upload functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/tests.yml | New workflow that installs and runs Kodi on Ubuntu for testing |
| .github/workflows/pythonpackage.yml | Removes existing Windows-based Python package workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adds push event
This reverts commit e192f8c.
Remov
Adds some dependencies
Adds preliminary Linux support to KodiInfo
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub Actions support for testing with a running Kodi instance on Linux, replacing the existing Windows-based test workflow. The changes enable cross-platform testing by adding Linux support to the KodiInfo module and introducing a new GitHub workflow that installs and runs Kodi in a headless environment.
Key changes:
- Extended KodiInfo.py to support Linux platform detection and URL generation
- Added new GitHub Actions workflow for testing with a running Kodi instance
- Removed the existing Windows-specific Python package workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| jsbc/KodiLib/KodiInfo.py | Added Linux platform support with URL generation logic |
| .github/workflows/tests.yml | New workflow for testing with Kodi on Ubuntu |
| .github/workflows/pythonpackage.yml | Removed existing Windows-based test workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Wait for Kodi to load using sleep
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow for testing with a running Kodi instance and updates the KodiInfo module to support Linux platforms. The changes enable the project to run automated tests in a Linux environment with Kodi running in a headless mode using xvfb.
- Adds Linux platform support to the KodiInfo module for retrieving Kodi release information
- Creates a new GitHub Actions workflow that installs and runs Kodi on Ubuntu for testing
- Removes the existing Windows-based Python package workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| jsbc/KodiLib/KodiInfo.py | Adds Linux platform detection and handling for Kodi version retrieval |
| .github/workflows/tests.yml | New workflow that sets up Kodi on Ubuntu and runs tests with pytest |
| .github/workflows/pythonpackage.yml | Removes the existing Windows-based testing workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.