Skip to content

Adds GitHub action with a running Kodi for testing#58

Merged
jonisb merged 22 commits intomasterfrom
kodicmd
Aug 25, 2025
Merged

Adds GitHub action with a running Kodi for testing#58
jonisb merged 22 commits intomasterfrom
kodicmd

Conversation

@jonisb
Copy link
Owner

@jonisb jonisb commented Aug 24, 2025

No description provided.

This comment was marked as outdated.

@jonisb jonisb moved this from TODO to Research in Research what is needed for KodiLib Aug 24, 2025
@jonisb jonisb moved this from Research to In progress in Research what is needed for KodiLib Aug 24, 2025
@jonisb jonisb requested a review from Copilot August 24, 2025 03:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new GitHub Actions workflow for testing with a running Kodi instance and removes the existing Python package workflow. The changes shift from a Windows-based multi-version testing approach to a simpler Ubuntu-based workflow that runs Kodi in a headless environment.

  • Replaces complex Windows-based workflow with simpler Ubuntu workflow
  • Adds Kodi installation and execution in headless mode using xvfb
  • Maintains test execution and artifact upload functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/tests.yml New workflow that installs and runs Kodi on Ubuntu for testing
.github/workflows/pythonpackage.yml Removes existing Windows-based Python package workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jonisb and others added 4 commits August 24, 2025 05:45

This comment was marked as outdated.

@jonisb jonisb marked this pull request as ready for review August 24, 2025 07:37
@jonisb jonisb requested a review from Copilot August 24, 2025 07:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub Actions support for testing with a running Kodi instance on Linux, replacing the existing Windows-based test workflow. The changes enable cross-platform testing by adding Linux support to the KodiInfo module and introducing a new GitHub workflow that installs and runs Kodi in a headless environment.

Key changes:

  • Extended KodiInfo.py to support Linux platform detection and URL generation
  • Added new GitHub Actions workflow for testing with a running Kodi instance
  • Removed the existing Windows-specific Python package workflow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
jsbc/KodiLib/KodiInfo.py Added Linux platform support with URL generation logic
.github/workflows/tests.yml New workflow for testing with Kodi on Ubuntu
.github/workflows/pythonpackage.yml Removed existing Windows-based test workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This comment was marked as outdated.

@jonisb jonisb requested a review from Copilot August 24, 2025 08:37

This comment was marked as outdated.

@jonisb jonisb requested a review from Copilot August 25, 2025 06:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow for testing with a running Kodi instance and updates the KodiInfo module to support Linux platforms. The changes enable the project to run automated tests in a Linux environment with Kodi running in a headless mode using xvfb.

  • Adds Linux platform support to the KodiInfo module for retrieving Kodi release information
  • Creates a new GitHub Actions workflow that installs and runs Kodi on Ubuntu for testing
  • Removes the existing Windows-based Python package workflow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
jsbc/KodiLib/KodiInfo.py Adds Linux platform detection and handling for Kodi version retrieval
.github/workflows/tests.yml New workflow that sets up Kodi on Ubuntu and runs tests with pytest
.github/workflows/pythonpackage.yml Removes the existing Windows-based testing workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jonisb jonisb merged commit ace76dd into master Aug 25, 2025
1 check passed
@jonisb jonisb moved this from In progress to Testing in Research what is needed for KodiLib Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants