Switch from libflate to flate2#361
Open
mkrasnitski wants to merge 1 commit intojonhoo:mainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 21 21
Lines 4272 4272
=======================================
Hits 3897 3897
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
flate2crate is more popular and as far as I can tell,infernomakes no attempt to beno_std. TheGzDecoder::newconstructor is infallible becauselibflateattempts to read and validate the gzip header on construction, whereasflate2does not and waits until the decoder is actually used to perform validation. Additionally,flate2uses aBufReaderinternally, thoughGzDecoderonly exposes aReadinterface.