Avoid duplicate utf8 parsing#22
Open
jduck wants to merge 1 commit intojonhoo:mainfrom
Open
Conversation
I spent 2 hours yelling at my screen about this one when I watched your 10 hour YouTube video today. Hope this change helps get the runtime under 1 second.
Contributor
|
Can you share the benchmark numbers here? |
Author
|
I can't because I don't have the dataset that Jon was using. I tested with a the dataset in the repo and it was a slight improvement. |
|
As far as I understand, the BTreeMap is needed so that the output will be sorted by station names. |
Author
Shouldn't the data already be sorted? This is only in the print() function, which should not need to convert the string from UTF-8 AGAIN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent 2 hours yelling at my screen about this one when I watched your 10 hour
YouTube video today. Hope this change helps get the runtime under 1 second.
-jduck