feat(simd-split-at-semicolon): Semicolon index calculation using SIMD (~= 10%)#21
Open
manuelgdlvh wants to merge 1 commit intojonhoo:mainfrom
Open
feat(simd-split-at-semicolon): Semicolon index calculation using SIMD (~= 10%)#21manuelgdlvh wants to merge 1 commit intojonhoo:mainfrom
manuelgdlvh wants to merge 1 commit intojonhoo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIMD works best when we don’t need extra assumptions or manual data alignment, and when all calculations are data simple pipeline transformations.
Thanks to the guarantees discussed in #2 (comment) about where the ; can appear (between buffer_len - 7 and buffer_len - 4), we can safely use a u8x4 SIMD search and get his max power.
With this change, the computation time goes below 700 milliseconds.
Before

After

I also made a small change in find_new_line(), related to an edge case.
When there are no more aligned-lane chunks, it is usually better to use a scalar calculation at the end instead of aligning the buffer to use SIMD.
This has no high impact, since this path is executed very few times.