Slightly optimized print#19
Open
WardLordRuby wants to merge 1 commit intojonhoo:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting the code to use multiple threads in the live stream it was needed to convert
StrVeckeys into an owned type,Stringwhen receiving chunks processed by threads. Thus making the latterstr::from_utf8mapping from withinprint, for ordering btree map keys, no longer necessary.Also by special casing the
is_emptycondition of the btree map we are able to avoid placing commas depending if there is a next element in the iterator.This provided a negligible ~0.05s run time improvement on my machine (8c/16t). Though I am not sure if there is a better way to avoid code duplication other than using
format_args!that would result in more efficient assembly.