Add explicit cleanup of memory-mapped file handles (windows)#18
Open
WardLordRuby wants to merge 2 commits intojonhoo:mainfrom
Open
Add explicit cleanup of memory-mapped file handles (windows)#18WardLordRuby wants to merge 2 commits intojonhoo:mainfrom
WardLordRuby wants to merge 2 commits intojonhoo:mainfrom
Conversation
A new method feels much more idiomatic than a free standing function
WardLordRuby
force-pushed
the
win-cleanup
branch
from
8b367bd to
fa5837b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly call
UnmapViewOfFileandCloseHandleto release the memory-mapped file resources. In this case where the memory map lives for the entire duration of the program windows would clean them up on process exit, however this commit has the added benefit of minimizing the diff if anyone decides to add platform-specific code in the future.