Add JSON output to config check - #383
Merged
Merged
Conversation
Closes #378 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3f892a21-0f5d-41e7-aebb-afbda057615d
The JSON refactor dropped the "Config: <path>" line from the text output when loadKeymap returns an error, which the previous checkKeybindings always printed. Restore the else branch so it matches the sibling config-load-error path in the same function. Adds a regression test that fails without the fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 951180a3-9772-4cf6-8e49-372d43653508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378
Adds
grut config check --jsonfor setup scripts that need a stable config validation report.Changes:
ok,config_path, load errors, and keybinding conflicts as JSON.Validation:
go build ./...go test ./cmd -run ConfigCheck -count=1go test ./... -count=1mage preflightwas attempted. It is blocked by WSL tests wheregitis not available in the WSL PATH.