Allow crash reports to be shown by short ID - #376
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e02217cd-ffed-496e-b8ea-848a781cda64
runReportShow now resolves reports through List plus findCrashReport, so Read had no remaining callers and the deadcode gate failed on it. Removes the function and its two orphaned tests, and reworks TestWriteAndRead to verify the written report through List. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 66a101e5-8e3c-41f0-bcf4-e26e7a44f1ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets
grut report --showaccept an unambiguous crash report ID prefix, matching the shortened IDs users see ingrut report --list.Changes:
Validation:
go build ./...go test ./...mage preflightfailed on existing lint findings ininternal\panels\gitinfo\gitinfo_submodules.goandinternal\panels\gitdiff\gitdiff.go.Closes #373