Skip to content

fix(mage): report PATH changes clearly during install #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jongio merged 1 commit into from
Jul 18, 2026
Merged

fix(mage): report PATH changes clearly during install #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions magefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,15 +450,22 @@ func ensurePath() error {
return nil
}

fmt.Printf("\n=== Adding %s to system PATH ===\n", binDir)
newPath := binDir + ";" + machinePath
err := exec.Command("powershell", "-NoProfile", "-Command",
fmt.Sprintf(`[Environment]::SetEnvironmentVariable('Path','%s','Machine')`, newPath)).Run()
if err != nil {
fmt.Println(" Machine PATH failed (need admin), trying User PATH...")
if !containsPath(userPath, binDir) {
exec.Command("powershell", "-NoProfile", "-Command",
fmt.Sprintf(`[Environment]::SetEnvironmentVariable('Path','%s;%s','User')`, binDir, userPath)).Run()
fmt.Printf("\n=== Adding %s to PATH ===\n", binDir)
// Prefer Machine PATH (visible to every user) but fall back to User PATH,
// which does not need administrator rights. Report the outcome either way
// so a failed persist is never silent.
machineErr := exec.Command("powershell", "-NoProfile", "-Command",
fmt.Sprintf(`[Environment]::SetEnvironmentVariable('Path','%s;%s','Machine')`, binDir, machinePath)).Run()
if machineErr == nil {
fmt.Println(" Added to Machine PATH.")
} else {
fmt.Println(" Machine PATH needs admin; adding to User PATH instead...")
if userErr := exec.Command("powershell", "-NoProfile", "-Command",
fmt.Sprintf(`[Environment]::SetEnvironmentVariable('Path','%s;%s','User')`, binDir, userPath)).Run(); userErr != nil {
fmt.Printf(" WARNING: could not add %s to User PATH: %v\n", binDir, userErr)
fmt.Println(" Add it manually, or re-run `mage install` from an elevated terminal.")
} else {
fmt.Println(" Added to User PATH.")
}
}
ensureSessionPath(binDir)
Expand Down Expand Up @@ -555,6 +562,7 @@ func verify() error {
fmt.Printf("\n✅ %s installed\n", binaryName())
fmt.Printf(" Path: %s\n", outPath)
fmt.Printf(" Built: %s\n", info.ModTime().Format(time.DateTime))
fmt.Printf(" Run: open a new terminal, then `%s` (already-open shells keep the old PATH)\n", binName)
return nil
}

Expand Down