Conversation
The 0.1.1 consent gate disclosed Cloudflare Workers AI screening of display names and bios to Apple, but not to members — including on the onboarding screen where they now must accept the Terms. Disclose it on that screen, at Settings > Privacy, and in docs/PRIVACY.md. Extract CURRENT_POLICY_VERSION and an isCurrentPolicy() type guard into src/lib/policy.ts so a settings screen can check consent without importing onboarding state, and so "accepted" has one definition rather than four repeated version comparisons. Settings > Terms now reads the stored record and shows which version the account accepted and when; previously getPolicyAcceptance() had no callers. Type savePolicyAcceptance as StoredPolicyAcceptance instead of object, which surfaced a pubkey that could be written null. Guard it, validate shape on read so a truncated record reads as no acceptance, and fail the acceptance write with an actionable message. The write stays fatal: a profile must not go live without a durable consent record. Align DEPLOYMENT.md and CLAUDE.md with ROADMAP-1.0.md, which no longer treats 0.1.1 as approved. The manifest still has a null gitSha and null artifact IDs, so assert-release-ready.mjs refuses production builds. The iOS tested-device table stays Android-only pending a real iPad walkthrough; it must not list untested devices. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PR #2, #8, #9 — merged: all comments were verified addressed. PR #10 — open — five remaining comments fixed: 1. privacy.tsx — replace hand-rolled Pressable checkbox with @expo/ui Switch 2. review.tsx — bind savePolicyAcceptance to identity.pubkey (authoritative) 3. terms.tsx — add loading/error states to useAcceptanceSummary 4. terms.tsx + use-auth.ts — clear POLICY_ACCEPTANCE on logout 5. policy.ts — add isValidPolicyTimestamp() guard against malformed dates 6. storage/index.ts — switch policy acceptance from SecureStore (silent in-memory fallback) to AsyncStorage (true durable persistence) Docs: README.md and RELEASE-STATUS.md now say proposed launch candidate, aligned with CLAUDE.md and ROADMAP-1.0.md. Build infra (carried from earlier in the session): - scripts/build-ios.sh — add -allowProvisioningUpdates to export step, pass DEVELOPMENT_TEAM from build.config.env - .gitignore — add build.config.env Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # security/audit-exceptions.json # src/app/settings/terms.tsx # src/lib/__tests__/policy.test.ts # src/lib/policy.ts
# Conflicts: # docs/APP-REVIEW-NOTES.md # docs/GUIDELINE-4.3B-RESPONSE.md # docs/ROADMAP-1.0.md # docs/STORE_LISTING.md # src/app/(tabs)/discover.tsx # src/app/(tabs)/passport.tsx # src/features/discovery/__tests__/private-introduction.test.ts # src/features/discovery/private-introduction.ts # store.config.json
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- publish the complete Expo web application\n- include encrypted browser identity and core dating flows\n- add RevenueCat lifetime-theme support and App Review evidence\n- publish the verified six-image Devpost gallery packet\n\n## Validation\n\n- CI 33277599331 passed\n- TypeScript, ESLint, tests, security policy, and web export passed\n- live Devpost gallery shows six exact 1179 x 2556 screenshots