fix: external-dns cloudflare.proxied key doesn't exist, use extraArgs - #30
Merged
Merged
Conversation
…s key cloudflare.proxied is not a key in the external-dns chart's schema, so it was silently dropped and all Cloudflare records stayed DNS-only.
Helm template diffdiff -u --recursive --label base --label head base head
--- base
+++ head
@@ -144,6 +144,7 @@
- --registry=txt
- --txt-owner-id=dieubernetes
- --provider=cloudflare
+ - --cloudflare-proxied
ports:
- name: http
protocol: TCP
diff -u --recursive --label base --label head base head
--- base
+++ head
@@ -218,7 +218,7 @@
app.kubernetes.io/managed-by: Helm
type: Opaque
data:
- SECRET_KEY_BASE: eXhDdnZjNnNnNURZMXpGQlg4Um1ac2JXeTFYbFNxcEZxcEhpVXZYWUUyTjV1YzduWDZIV1R4eGs3NE0zM2tBZ3UyR0FURDhmQ0xibkQydERvalA3N0FxaWZz
+ SECRET_KEY_BASE: QkVQcnBZZHZPUmg1NGV3d3BVamNMSUJFYWVzSnZ2c3I4SzlUVHlFWGJUYzVxQlpoOTE1ZkRBVXZQMlZTc3M4c2F6OXVObko5WFBuYVlVWmJyTElwY0tid25N
TOTP_VAULT_KEY: ZHN4dmJuM2p4RGQxNmF6MlFwc1g1QjhPK2xseGpRMlNKRTJpNUJ6eDM4ST0=
DATABASE_URL: cG9zdGdyZXM6Ly9wb3N0Z3Jlczpwb3N0Z3Jlc0BwbGF1c2libGUtYW5hbHl0aWNzLXBvc3RncmVzcWw6NTQzMi9wbGF1c2libGVfZGI=
CLICKHOUSE_DATABASE_URL: aHR0cDovL2NsaWNraG91c2U6cGFzc3dvcmRAcGxhdXNpYmxlLWFuYWx5dGljcy1jbGlja2hvdXNlOjgxMjMvcGxhdXNpYmxlX2V2ZW50c19kYg== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloudflare.proxied isn't a real key in the external-dns chart (checked the 1.21.1 schema, no cloudflare block exists). It was silently dropped, so records stayed DNS-only. --cloudflare-proxied has to go through extraArgs instead.