Repository navigation
Conversation
An acknowledged bank-changing SELECT remained provisional, but immediate banked access rejected it before the RDBUFF barrier could settle it. Wide-address release needed SELECT1 and could therefore remain stuck on every retry, retaining power and response-mode ownership. Settle that selection before banked access. If a WAIT makes the underlying SWD connection require repair, invalidate DAP framing too. Honor the explicit release context during re-entry and preserve independent recovery budgets inside failed operations. An out-of-range AP base at ASIZE 32 also needs a regression because truncating it could silently select another AP.
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banked DP accesses now settle a pending SELECT through RDBUFF before using or changing the bank. Previously, an immediate SELECT write could make those accesses fail without traffic and strand Release on an ADIv6 port with an address width above 32 bits. SELECT1 access and release retries now make progress on 40-, 48-, and 52-bit ports.
If a WAIT during SELECT confirmation leaves the SWD connection requiring repair, DAP also requires protocol re-entry. Explicit Release attempts use the supplied context for re-entry and restoration; a canceled context sends no traffic. Recovery inside a failed transport operation retains its independent budget.
Why
A SELECT acknowledgement precedes the write data, so it does not establish that the new bank took effect. RDBUFF can settle the write without guessing which bank is active. A failed confirmation stops the requested banked access, while a later release can retry cleanup with a fresh context. The release test observes restored power, response mode, and upper address selection through the target model.
On an ASIZE-32 port, an AP base at or above 4 GiB must be rejected before traffic; truncating it could select a different AP.
Documentation
The DAP guide describes the selection barrier and release retry behavior. The Release documentation specifies the caller's context and distinguishes it from recovery performed inside a failed transport operation.