Skip to content

Fix canonical integers and truncation errors - #319

Merged
mrabine merged 4 commits into
mainfrom
feature/json-cbor-fixes
Nov 14, 2026
Merged

mrabine merged 4 commits into
mainfrom
feature/json-cbor-fixes

Conversation

@mrabine

@mrabine mrabine commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production

codacy-production Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 30 complexity · 21 duplication

Metric Results
Complexity 30
Duplication 21

View in Codacy

🟢 Coverage 98.63% diff coverage · 0.00% coverage variation

Metric Results
Coverage variation ✅ 0.00% coverage variation
Diff coverage ✅ 98.63% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (83a24fa) 16234 15987 98.48%
Head commit (86c45e9) 16291 (+57) 16043 (+56) 98.48% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#319) 73 72 98.63%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.54%. Comparing base (83a24fa) to head (86c45e9).

Files with missing lines Patch % Lines
data/include/join/cbor.hpp 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   98.54%   98.54%   -0.01%     
==========================================
  Files         134      134              
  Lines       15310    15367      +57     
==========================================
+ Hits        15088    15144      +56     
- Misses        222      223       +1     
Flag Coverage Δ
unittests 98.54% <98.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented Nov 14, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 43631871071

Coverage decreased (-0.001%) to 98.478%

Details

  • Coverage decreased (-0.001%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (72 of 73 lines covered, 98.63%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
data/include/join/cbor.hpp 39 38 97.44%
Total (3 files) 73 72 98.63%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16291
Covered Lines: 16043
Line Coverage: 98.48%
Coverage Strength: 146759.64 hits per line

💛 - Coveralls

@mrabine
mrabine merged commit c0b4596 into main Nov 14, 2026
23 of 24 checks passed
@mrabine
mrabine deleted the feature/json-cbor-fixes branch November 14, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants