Skip to content

Use dconv 1.2.3 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrabine merged 1 commit into from
Nov 12, 2026
Merged

Use dconv 1.2.3 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ sudo apt install pkg-config libssl-dev zlib1g-dev libgtest-dev libgmock-dev

Install [dconv](https://github.com/joinframework/dconv) from its release package:
```bash
wget https://github.com/joinframework/dconv/releases/download/v1.2.1/libdconv-dev_1.2.1_all.deb
sudo apt install ./libdconv-dev_1.2.1_all.deb
wget https://github.com/joinframework/dconv/releases/download/v1.2.3/libdconv-dev_1.2.3_all.deb
sudo apt install ./libdconv-dev_1.2.3_all.deb
```

> **Compilers:** GCC 11+ or Clang 16+ (C++20). Clang requires `libclang-rt-dev` for coverage instrumentation (`--coverage`).
Expand Down
2 changes: 1 addition & 1 deletion cmake/joinConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ foreach(comp ${join_FIND_COMPONENTS})
endforeach()

if(@JOIN_ENABLE_DATA@ OR @JOIN_ENABLE_SERVICES@)
find_dependency(dconv 1.2.1)
find_dependency(dconv 1.2.3)
find_dependency(ZLIB)
endif()

Expand Down
2 changes: 1 addition & 1 deletion cmake/packaging.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ if(JOIN_ENABLE_CRYPTO)
string(APPEND JOIN_DEV_DEPENDS ", libssl-dev")
endif()
if(JOIN_ENABLE_DATA)
string(APPEND JOIN_DEV_DEPENDS ", libdconv-dev (>= 1.2.1), zlib1g-dev")
string(APPEND JOIN_DEV_DEPENDS ", libdconv-dev (>= 1.2.3), zlib1g-dev")
endif()
if(JOIN_ENABLE_IO_URING)
string(APPEND JOIN_DEV_DEPENDS ", liburing-dev")
Expand Down
2 changes: 1 addition & 1 deletion data/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.22.1)

find_package(dconv 1.2.1 REQUIRED)
find_package(dconv 1.2.3 REQUIRED)
find_package(ZLIB REQUIRED)

set(PUBLIC_HEADERS
Expand Down
Loading