Skip to content

Value templates #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrabine merged 2 commits into from
Nov 11, 2026
Merged

Value templates #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4628479
Replace Value per-type overloads with templates
mrabine Nov 11, 2026
5024ab2
Template scalar overloads
mrabine Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 3 additions & 149 deletions data/include/join/json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,83 +545,12 @@ namespace join
}

/**
* @brief set null key.
* @brief set scalar key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] std::nullptr_t key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
return -1;
}

/**
* @brief set boolean key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] bool key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
return -1;
}

/**
* @brief set integer key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] int32_t key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
return -1;
}

/**
* @brief set unsigned integer key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] uint32_t key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
return -1;
}

/**
* @brief set 64 bits integer key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] int64_t key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
return -1;
}

/**
* @brief set unsigned 64 bits integer key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] uint64_t key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
return -1;
}

/**
* @brief set real key.
* @param key object key.
* @return -1.
*/
int setKey ([[maybe_unused]] double key)
template <Scalar Key>
int setKey ([[maybe_unused]] Key key)
{
join::lastError = make_error_code (SaxErrc::InvalidKey);
reset ();
Expand Down Expand Up @@ -661,16 +590,6 @@ namespace join
return 0;
}

/**
* @brief set string key.
* @param key object key.
* @return 0 on success, -1 otherwise.
*/
int setKey (const char* key)
{
return setKey (std::string_view (key));
}

/**
* @brief set binary key.
* @param key object key.
Expand Down Expand Up @@ -1244,71 +1163,6 @@ namespace join
return read (in, handler);
}

/**
* @brief deserialize a document.
* @param document document to deserialize.
* @param handler handler receiving the document.
* @return 0 on success, -1 otherwise.
*/
template <typename Handler>
int deserialize (std::stringstream& document, Handler& handler)
{
dconv::StreamProbe in (document);
return read (in, handler);
}

/**
* @brief deserialize a document.
* @param document document to deserialize.
* @param handler handler receiving the document.
* @return 0 on success, -1 otherwise.
*/
template <typename Handler>
int deserialize (std::istringstream& document, Handler& handler)
{
dconv::StreamProbe in (document);
return read (in, handler);
}

/**
* @brief deserialize a document.
* @param document document to deserialize.
* @param handler handler receiving the document.
* @return 0 on success, -1 otherwise.
*/
template <typename Handler>
int deserialize (std::fstream& document, Handler& handler)
{
dconv::StreamProbe in (document);
return read (in, handler);
}

/**
* @brief deserialize a document.
* @param document document to deserialize.
* @param handler handler receiving the document.
* @return 0 on success, -1 otherwise.
*/
template <typename Handler>
int deserialize (std::ifstream& document, Handler& handler)
{
dconv::StreamProbe in (document);
return read (in, handler);
}

/**
* @brief deserialize a document.
* @param document document to deserialize.
* @param handler handler receiving the document.
* @return 0 on success, -1 otherwise.
*/
template <typename Handler>
int deserialize (std::iostream& document, Handler& handler)
{
dconv::StreamProbe in (document);
return read (in, handler);
}

/**
* @brief deserialize a document.
* @param document document to deserialize.
Expand Down
Loading
Loading