Skip to content

Value binary size #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrabine merged 1 commit into from
Nov 10, 2026
Merged

Value binary size #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/include/join/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2225,6 +2225,9 @@ namespace join
case StringValue:
return _data.template get<StringValue> ().empty ();

case BinaryValue:
return _data.template get<BinaryValue> ().data.empty ();

case ArrayValue:
return _data.template get<ArrayValue> ().empty ();

Expand All @@ -2250,6 +2253,9 @@ namespace join
case StringValue:
return _data.template get<StringValue> ().size ();

case BinaryValue:
return _data.template get<BinaryValue> ().data.size ();

case ArrayValue:
return _data.template get<ArrayValue> ().size ();

Expand Down
14 changes: 14 additions & 0 deletions data/tests/value_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4990,6 +4990,13 @@ TEST (Value, empty)
value = "127.0.0.1";
ASSERT_FALSE (value.empty ());

const uint8_t bytes[] = {0x00, 0x01, 0xff};
value = std::span<const uint8_t> ();
ASSERT_TRUE (value.empty ());

value = std::span<const uint8_t> (bytes, sizeof (bytes));
ASSERT_FALSE (value.empty ());

value = Array ();
ASSERT_TRUE (value.empty ());

Expand Down Expand Up @@ -5098,6 +5105,13 @@ TEST (Value, size)
value = "127.0.0.1";
ASSERT_EQ (value.size (), 9);

const uint8_t bytes[] = {0x00, 0x01, 0xff};
value = std::span<const uint8_t> ();
ASSERT_EQ (value.size (), 0);

value = std::span<const uint8_t> (bytes, sizeof (bytes));
ASSERT_EQ (value.size (), 3);

value = array.getArray ();
ASSERT_EQ (value.size (), 1);

Expand Down
Loading