Repository navigation
fix: restore mobile keyboard focus when selecting session tabs - #36
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a mobile session could leave terminal input unfocused when the keyboard was hidden. A quick tab-sheet selection could also focus the terminal and then lose it to the closed sheet's uncancelled 180 ms search-focus timer. Tapping the active tab returned before focusing.
Explicit tab taps now synchronously focus terminal input (including the active tab); app-driven restore stays passive when the keyboard is hidden. Closing the mobile sheet cancels and guards search autofocus, then routes selection through the same stale-focus reset as ordinary tab taps.
Fixes #35.
Validation: six browser DOM/focus tests; 172 related tests; required static checks and isolated build. A full mobile page with two disposable shell tabs preserved focus after ordinary switching and immediate same-tab selection, with no page errors. Browser emulation does not prove native iOS keyboard display; physical-device verification remains necessary. Broader smoke retains two known long-scrollback wheel failures also recorded on the unchanged baseline; no focus/console regression. No production-session input used.