Discard bandwidth from hamlib mode report, use correct level command to request RF power#5
Open
mattmelling wants to merge 1 commit intojohnsonm:mainfrom
Open
Discard bandwidth from hamlib mode report, use correct level command to request RF power#5mattmelling wants to merge 1 commit intojohnsonm:mainfrom
mattmelling wants to merge 1 commit intojohnsonm:mainfrom
Conversation
mattmelling
force-pushed
the
fix-hamlib-power
branch
2 times, most recently
from
9cd0327 to
7d399f1
Compare
mattmelling
force-pushed
the
fix-hamlib-power
branch
from
7d399f1 to
8ac389c
Compare
mattmelling
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently read the mode and bandwidth from hamlib as
However hamlib actually returns these as separate lines:
The extra line causes the next read (power) to consume the second line (bandwidth), leading to incorrect power settings being reported to hamlib.
The correct command to read the power level setting from hamlib is
(
l= level, this is read RF power level)Fixes #4 and uses the correct command to read the RF power level.