Closed
Conversation
- Replaced pre-commit hooks with ruff for linting, formatting, and import sorting - Removed dependencies: flake8, pre-commit, flake8-type-checking, black, isort - Added ruff configuration in pyproject.toml with comprehensive linting rules - Updated CI workflow to run ruff check, ruff format, and mypy separately - Updated README with new ruff-based code quality instructions - Applied automatic code fixes and formatting via ruff - Kept mypy as separate type checker for comprehensive type validation Benefits: - Faster execution (ruff is written in Rust) - Unified tooling instead of multiple separate tools - Better integration with uv ecosystem - More comprehensive linting rules out of the box 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Created setup-git-hooks.sh script to install a custom git pre-commit hook - Hook runs ruff check and ruff format --check on main package directories - Updated README with git hook setup instructions - Added TC002 to ruff ignore list (type-checking import rules need careful handling) - Provides clear error messages and auto-fix suggestions - Can be bypassed with --no-verify when needed Benefits: - Automatic code quality checks before each commit - Fast feedback loop for developers - No additional tool dependencies (uses existing uv + ruff) - Cleaner than pre-commit framework for this simple use case 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
d29ddd9 to
cb18f92
Compare
Owner
Author
|
Added to #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup-git-hooks.shscript for easy installationWhat this adds
setup-git-hooks.sh: Installation script for the git hookruff checkandruff format --checkautomaticallyHow it works
./setup-git-hooks.shto install the hookgit commitgit commit --no-verifywhen neededBenefits
Test plan
--no-verify🤖 Generated with Claude Code