Skip to content

Demo: @model bug persists on #21460 (guard removed)#35

Draft
johanrd wants to merge 1 commit into
rfc-1169-route-managerfrom
demo/model-stability-persists-without-guard
Draft

Demo: @model bug persists on #21460 (guard removed)#35
johanrd wants to merge 1 commit into
rfc-1169-route-managerfrom
demo/model-stability-persists-without-guard

Conversation

@johanrd

@johanrd johanrd commented Jun 10, 2026

Copy link
Copy Markdown
Owner

double check if the problem still persists

yes, it persists

tried emberjs#21460 now, restoring the logic to the current ember-7.0.0 behavior:

   wrapperArgs['model'] = createComputeRef(() => {
     if (lastState === state) {
-      let currentOutlet = valueForRef(outletRef);
-      if (currentOutlet?.render?.controller === controller) {
-        model = valueForRef(modelRef);
-      }
+      model = valueForRef(modelRef);
     }
     return model;
   });
Test Expected emberjs#21460 emberjs#21460 with guard removed
@model stable when transitioning out of the route b,b,b,b,b b,b,b,b,b ❌️ b,b,d,e,
@model updates when the model changes on the same route third third third
@model stable when grandparent outlet tears down i i ❌️ (undefined)

…s on emberjs#21460

Reverts the outlet.ts compute-ref guard to the current ember-7.0.0 behavior,
demonstrating that the @model-during-willDestroy instability (emberjs#18987)
still reproduces on top of the Route Manager RFC implementation (emberjs#21460).

The smoke-test job's '@model stability during route transitions' tests are
expected to fail here. Not for merge.
@github-actions

Copy link
Copy Markdown

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   -0.01%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/api-{hash}.js 10.1 kB / 2.3 kB 146%↑24.8 kB / 140%↑5.4 kB
./packages/shared-chunks/cache-{hash}.js 697 B / 258 B 2,460%↑17.9 kB / 1,760%↑4.8 kB
./packages/shared-chunks/index-{hash}.js 75.6 kB / 18.3 kB -0.19%↓75.5 kB / -0.14%↓18.2 kB
Total (Includes all files) 2.1 MB / 502.5 kB -0.01%↓2.1 MB / -0%↓502.5 kB

dist/prod   -0.01%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/cache-{hash}.js 697 B / 258 B 1,320%↑9.9 kB / 982%↑2.8 kB
./packages/shared-chunks/index-{hash}.js 64.1 kB / 15.7 kB -0.22%↓64 kB / -0.15%↓15.6 kB
Total (Includes all files) 1.9 MB / 460.3 kB -0.01%↓1.9 MB / -0%↓460.3 kB

smoke-tests/v2-app-hello-world-template/dist   -0.01%↓

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 241 kB / 65.9 kB -0.01%↓241 kB / 0.02%↑65.9 kB

🤖 This report was automatically generated by wyvox/pkg-size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant