Skip to content

feat(agents): add AgentOverrides and FlowAgentOverrides types#44

Merged
zrosenbauer merged 2 commits intomainfrom
feat/agent-overrides-type
Mar 20, 2026
Merged

feat(agents): add AgentOverrides and FlowAgentOverrides types#44
zrosenbauer merged 2 commits intomainfrom
feat/agent-overrides-type

Conversation

@zrosenbauer
Copy link
Member

Summary

  • Extracts dedicated AgentOverrides and FlowAgentOverrides type aliases from the inline evolve() overload signatures
  • Re-exports both types from @funkai/agents so consumers can reference them directly
  • Updates evolve() overload signatures to use the new types (no runtime changes)

Test plan

  • pnpm typecheck --filter=@funkai/agents passes
  • pnpm build --filter=@funkai/agents passes
  • Existing evolve.test.ts tests still pass

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
funkai Ignored Ignored Preview Mar 20, 2026 3:09am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2026

🦋 Changeset detected

Latest commit: 7e242f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@funkai/agents Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a7614164-6b5f-4e21-96ae-bb2b5495dc69

📥 Commits

Reviewing files that changed from the base of the PR and between 395892d and 7e242f3.

📒 Files selected for processing (1)
  • packages/agents/src/core/agents/evolve.ts

📝 Walkthrough

Walkthrough

Adds two exported types, AgentOverrides and FlowAgentOverrides, and updates evolve() TypeScript overloads to use these types; re-exports the new types and adds a changeset. No runtime behavior changes.

Changes

Cohort / File(s) Summary
Changelog
\.changeset/agent-overrides-type.md
New changeset declaring a minor release for @funkai/agents to introduce the override types.
Type definitions
packages/agents/src/core/agents/types.ts, packages/agents/src/core/agents/flow/types.ts
Added AgentOverrides<...> and FlowAgentOverrides<...> types representing Partial<...> or a mapper (config) => Partial<...>.
Evolve overloads
packages/agents/src/core/agents/evolve.ts
Replaced inline union types in evolve() overloads with AgentOverrides / FlowAgentOverrides; imports adjusted.
Public exports
packages/agents/src/index.ts
Re-exported AgentOverrides and FlowAgentOverrides from core modules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: introducing AgentOverrides and FlowAgentOverrides types extracted from evolve() signatures.
Description check ✅ Passed The description clearly relates to the changeset, detailing type extraction, re-exports, and the unchanged runtime behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/agents/src/core/agents/evolve.ts (1)

1-1: ⚠️ Potential issue | 🟡 Minor

CI failure: formatting check failed.

The pipeline reports oxfmt --check found formatting issues. Run oxfmt . from the repo root to fix.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/agents/src/core/agents/evolve.ts` at line 1, The CI failure
indicates formatting issues in packages/agents/src/core/agents/evolve.ts; run
the repository formatter (oxfmt .) from the repo root and re-stage the modified
files (including evolve.ts) so oxfmt --check passes; ensure you commit the
updated formatting and push the changes so the header comment and the rest of
evolve.ts match the project's oxfmt style.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@packages/agents/src/core/agents/evolve.ts`:
- Line 1: The CI failure indicates formatting issues in
packages/agents/src/core/agents/evolve.ts; run the repository formatter (oxfmt
.) from the repo root and re-stage the modified files (including evolve.ts) so
oxfmt --check passes; ensure you commit the updated formatting and push the
changes so the header comment and the rest of evolve.ts match the project's
oxfmt style.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a3d66de3-8654-4ac0-8f52-aba50483b633

📥 Commits

Reviewing files that changed from the base of the PR and between 2a8fc68 and 395892d.

📒 Files selected for processing (5)
  • .changeset/agent-overrides-type.md
  • packages/agents/src/core/agents/evolve.ts
  • packages/agents/src/core/agents/flow/types.ts
  • packages/agents/src/core/agents/types.ts
  • packages/agents/src/index.ts

Co-Authored-By: Claude <noreply@anthropic.com>
@zrosenbauer zrosenbauer merged commit 9679551 into main Mar 20, 2026
5 checks passed
@zrosenbauer zrosenbauer deleted the feat/agent-overrides-type branch March 20, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant