[codex] fix workbench mobile image previews - #6
Draft
joeymilano wants to merge 1 commit into
Draft
joeymilano wants to merge 1 commit into
joeymilano wants to merge 1 commit into
Conversation
Deploying finfold with
|
| Latest commit: |
bd42da1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f513f53b.finfold.pages.dev |
| Branch Preview URL: | https://codex-mobile-workbench-image.finfold.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The Workbench could overflow on mobile because nested grid/flex children and long labels were allowed to keep oversized minimum widths. The image generation PR also introduced platform previews where some generated image URLs were accepted but not actually rendered.
Validation
npm run typechecknpm testnpm run buildNotes
Image generation secrets are intentionally not committed. Production needs
IMAGE_API_KEYconfigured as a deployment secret.IMAGE_API_BASEandIMAGE_MODELare already present in config.