Remove Node engine upper bound#270
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d9f019f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit 17da4c6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<23upper bound from package manifests while keeping the published minimum at>=20tree-sitter@0.25.0so its native binding builds with C++20 instead of C++17patches/README.mdas a temporary backport of the upstream fixWhy
Node 26 failed during dependency installation because
tree-sitter@0.25.0compiled its native binding as C++17, while Node 26's V8 headers require C++20. C++20 is just the newer C++ language standard the compiler must use for that native addon.npm view tree-sitter version versions --jsonshows0.25.0is still the latest publishedtree-sitterruntime, so there is no newer runtime package to upgrade to for this failure. The practical fix is a small pnpm patch tobinding.gyp.The equivalent upstream fix was merged in tree-sitter/node-tree-sitter#258, but it has not reached npm because the 0.25.1 publish is still blocked by tree-sitter/node-tree-sitter#276. This local patch should be removed once
tree-sitterpublishes a release with the Node 23+ C++20 build fix. Follow-up Trello card: https://trello.com/c/Myxab48HCI remains pinned to Node
22.22.0; this PR broadens the published package engine range and fixes the known newer-Node install blocker without redesigning CI.Mac Mini Evidence
Remote worktree:
/Users/poleski/.codex/worktrees/270-node-engine-upper-bound/CodeGraphyV4Before patch:
Poleskis-Mac-mini.localv26.0.010.32.0pnpm install --frozen-lockfilefailed while buildingtree-sitter@0.25.0After patch:
Poleskis-Mac-mini.localv26.0.010.32.0pnpm install --frozen-lockfilepassedpnpm --filter @codegraphy-dev/core typecheckpassedpnpm --filter @codegraphy-dev/mcp testpassed: 1 file, 13 testsEarlier supported baseline:
v22.22.2pnpm install --frozen-lockfilepassedpnpm run typecheckpassedpnpm run lintpassed, with 32 generated-acceptance spacing warningspnpm --filter @codegraphy-dev/mcp testpassedpnpm run mutate -- packages/mcp/src/mcp/server.tspassed: 5 mutants, 100% mutation scoreLocal Verification
pnpm install --frozen-lockfilepassed on Nodev22.22.0pnpm run typecheckpassed for the engine/patch commitpnpm run typecheckpassed for the final evidence commitpnpm run typecheckpassed for the patch documentation commitGitHub CI
GitHub CI passed on the previous latest commit before the final docs-only evidence correction. The final commit only updates this handoff note.
Trello: https://trello.com/c/qiauqiPA