Open
Conversation
mpollmeier
reviewed
Jan 27, 2025
Contributor
mpollmeier
left a comment
There was a problem hiding this comment.
I'm in favor of bringing this in, but first please:
-
add a unit test
-
copy the good explanation from the PR description into the code, so it's accessible in the future, and in case we decide it becomes a maintance burden (which I doubt) we can safely revert it / kick it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces
scala.collection.mutable.LinkedHashMap[String, Int]with a custom dedup table for construction of the string-pool. That brings down serialization on my large test graph from ~2200ms to ~1700ms, i.e. does a hefty chunk.Main reason why this does so much is that all the string deduplication must be done serially, in order to allow us to get bitwise-reproducible results; and now that everything else is parallel, this means that this becomes a bottleneck if there are enough cores.
I'm pretty unsure whether the speedup is worth the maintenance hassle. If we don't want to merge, then it is fine to leave this PR open indefinitely, in case we want to resurrect it in the future.