fix(ci): run required tests when a PR is retargeted to main - #1
Closed
joebasrawi wants to merge 3 commits into
Closed
fix(ci): run required tests when a PR is retargeted to main#1joebasrawi wants to merge 3 commits into
joebasrawi wants to merge 3 commits into
Conversation
Subscribe the existing CI workflow to pull_request edited so a base-branch change onto main produces the required test check. Skip title and body edits, isolate them from the pull-request concurrency group, and report them under a different check name so they cannot cancel or satisfy test. Fixes apache#4181 Generated-by: Cursor Grok 4.6 Co-authored-by: Joseph B <joebasrawi@users.noreply.github.com>
joebasrawi
marked this pull request as ready for review
August 29, 2026 14:46
Generated-by: Cursor Grok 4.6 Co-authored-by: Joseph B <joebasrawi@users.noreply.github.com>
Generated-by: Cursor Grok 4.6 Co-authored-by: Joseph B <joebasrawi@users.noreply.github.com>
Owner
Author
|
Not opening this upstream. apache#4181 is assigned to jackeyfaker77 and already has apache#4186. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retargeting a pull request onto
maindid not start the requiredtestcheck. TheCIworkflow already filteredpull_requesttomain, but it used the default activity types (opened,synchronize,reopened). A base-branch change emitsedited, so a PR that was synced against another branch and then pointed atmainnever got a run for that revision. PR apache#4161 showed the gap.This keeps the existing
CI/testjob as the single required check:editedin addition to the default types.editedevent).ignored-pr-editinstead oftest, because a skipped job namedtestwould still satisfy the required check.Fixes apache#4181
This branch is based on current
apache/makamain. To open the same change on Apache:https://github.com/apache/maka/compare/main...joebasrawi:cursor/fix-ci-pr-retarget-f376?quick_pull=1
Verification
node --test --test-concurrency=1 scripts/ci-pull-request-trigger.test.mjs scripts/ci-test-plan.test.mjsnpx biome check scripts/ci-pull-request-trigger.mjs scripts/ci-pull-request-trigger.test.mjsnode scripts/asf-license-headers.mjs checkChanging
.github/workflows/ci.ymlselects the full CI plan. The forktestjob is in progress after a synchronize ontomain.AI use
Select exactly one:
Tool(s) and scope:
Cursor Grok 4.6 authored the workflow guard, the trigger policy module, and the regression tests.
Checklist
Does this PR entail a change in behavior?