Skip to content

Fix directory references in notebooks: 'example' to 'examples' and 'TMP' to '.tmp' - #4

Closed
jochym with Copilot wants to merge 4 commits into
copilot/check-ci-issue-solutionfrom
copilot/fix-directory-name-in-notebooks
Closed

jochym with Copilot wants to merge 4 commits into
copilot/check-ci-issue-solutionfrom
copilot/fix-directory-name-in-notebooks

Conversation

Copilot AI commented Dec 26, 2025 •

Copy link
Copy Markdown

Multiple notebooks referenced incorrect directory names, causing path resolution failures in CI.

Changes

  • Fixed example to examples directory: Updated 10 notebooks with 31 incorrect path references:
    • 02_CLI.ipynb (17 occurrences)
    • 03_monitor_stats.ipynb, 17_xscale.ipynb, and 7 others (2-3 occurrences each)
  • Changed TMP to .tmp directory: Updated 6 notebooks with 15 directory references:
    • 01_VASP_Tutorial.ipynb (2 occurrences)
    • 02_CLI.ipynb (3 occurrences)
    • 05_vasp_workflow.ipynb, 11_parwidth.ipynb, 16_util.ipynb, and 98_ase_smoketest.ipynb
  • Fixed scripts/fix_cli_paths.py helper to use correct directory names

Example changes:

# Before
base_dir = f'../example/VASP_3C-SiC/{supercell}/'
calc_dir = TemporaryDirectory(dir='../TMP')

# After
base_dir = f'../examples/VASP_3C-SiC/{supercell}/'
calc_dir = TemporaryDirectory(dir='../.tmp')
Original prompt

Reference: https://github.com/jochym/hecss/actions/runs/20518009335/job/5894896941 Name of the directory is wrong in several notebooks. It should be : examples not example . Fix it.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 26, 2025 07:31
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix directory name in several notebooks Fix directory references from 'example' to 'examples' in notebooks Dec 26, 2025
Copilot AI requested a review from jochym December 26, 2025 07:34

@jochym jochym left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, but the TMP directory needs to be changed to .tmp

Fix this @copilot

Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>

Copilot AI commented Dec 26, 2025

Copy link
Copy Markdown
Author

Much better, but the TMP directory needs to be changed to .tmp

Fix this @copilot

Done! Changed all TMP directory references to .tmp in notebooks and scripts. Commit: a54dd3f

Copilot AI changed the title Fix directory references from 'example' to 'examples' in notebooks Fix directory references in notebooks: 'example' to 'examples' and 'TMP' to '.tmp' Dec 26, 2025
Copilot AI requested a review from jochym December 26, 2025 07:44
@jochym jochym closed this Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants