This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix [Placeholder font handling] requested changes#103
Open
DamienBallenghien wants to merge 5 commits into
Open
Fix [Placeholder font handling] requested changes#103DamienBallenghien wants to merge 5 commits into
DamienBallenghien wants to merge 5 commits into
Conversation
Add placeholderFont property
…1-PlaceholderFont Add placeholderFont handling
victorBaro
approved these changes
Jul 17, 2018
victorBaro
left a comment
victorBaro
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Thank you for taking the time to add the requested changes.
Contributor
|
Can you please check the conflicts? I will merge it as soon as they are fixed |
iceman201
approved these changes
May 9, 2019
|
@victorBaro looks all good, can you merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied your requested changes regarding Zyoma108's PR (issue #91 on 11 Dec 2017) because this feature can be very appreciable !
Thank you for your very useful library !