[joaquinbejar]

Summary

ironfix-dictionary declared MIT but shipped four QuickFIX XML files under The QuickFIX Software License 1.0. This PR makes the embedded dictionaries load from the FIX Trading Community Orchestra repositories (Apache-2.0) instead, so the published crate carries no QuickFIX content.

Changes

• Embedded files. spec/orchestra/ holds four files, verbatim from orchestrations@cd24169a, with the upstream LICENSE and a provenance README. Upstream publishes no NOTICE file.

  Dictionary	Source
  FIX 4.2	OrchestraFIX42.xml
  FIX 4.4	OrchestraFIX44.xml
  FIXT 1.1	FIXTSession.xml
  FIX 5.0 SP2	derived from OrchestraFIXLatest.xml with from_orchestra_latest_xml (Load FIX 4.2, FIXT 1.1 and FIX 5.0 SP2 from FIX Orchestra (dictionary) #200)

• Public API. Dictionary::fix42(), fix44(), fixt11() and fix50sp2() keep their names, signatures and caching.

• QuickFIX files. They moved to tests/fixtures/quickfix/ together with LICENSE-QUICKFIX, and are excluded from the package. They remain for:

  • the QuickFIX-loader tests;
  • the equivalence diff;
  • the codegen tests for shared components. Orchestra 4.4 models Parties and similar blocks as groups, so those tests need the QuickFIX file.

• Tests and goldens. Tests that pinned QuickFIX content now follow Orchestra, as the owner decided. The FIX 4.2 and FIXT 1.1 goldens are regenerated.

• Docs.

  • ADR-0032 supersedes ADR-0010. The transport plus application composition from ADR-0010 still stands.
  • CHANGELOG.md is new and lists every user-observable difference.
  • README, doc/orchestra_differences.md and doc/fix_operations.md are updated.

Measurements

Apple M4 Max with 64 GB, release build, first call in a fresh process, 3 runs.

Dictionary	First load before	First load after
fix42	about 1.1 ms	4.2 to 6.8 ms
fix44	about 2.6 ms	6.4 to 9.2 ms
fixt11	about 0.14 ms	about 0.5 ms
fix50sp2	about 10 ms	29 to 33 ms

• A cached call takes about 42 ns, unchanged.
• The .crate grows from 356 441 bytes to 1 133 644 bytes. No compression and no new dependency were needed.

Public / contract impact

No pub item changes, but dictionary content and behaviour do, so this is a breaking change:

• field names change;
• more fields are enumerated, so validation can return new InvalidEnumValue errors;
• some deprecated SP2 fields are dropped;
• generated code changes shape: per-message group entry types replace the shared Parties-style component types.

The version bump and the per-crate licence metadata (MIT AND Apache-2.0) are in #202.

Testing

• cargo test --workspace: 2551 passed, 0 failed.
• clippy -D warnings, fmt, doc, check-spanish and the release build are clean.
• cargo package -p ironfix-dictionary --list contains only spec/orchestra/*.
• grep -ri quickfix ironfix-dictionary/spec finds nothing.

Stack: #200 (merged) → #201 (this) → #202.

Closes #201

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
ironfix-codegen/src/generator.rs	91.12% <ø> (ø)
ironfix-codegen/src/views.rs	97.57% <ø> (+0.20%)	⬆️
ironfix-core/src/message.rs	84.37% <ø> (ø)
ironfix-dictionary/src/composition.rs	69.56% <ø> (ø)
ironfix-dictionary/src/loader.rs	91.46% <100.00%> (+0.02%)	⬆️
ironfix-dictionary/src/orchestra.rs	94.44% <ø> (ø)
ironfix-dictionary/src/schema.rs	97.16% <ø> (ø)
ironfix-dictionary/src/validator.rs	96.73% <ø> (ø)
ironfix-engine/src/wire.rs	93.08% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.