Repository navigation
Fail CI when the FIXP schema enters the published crate (#203) - #204
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ironfix-fixp/spec/SBEschemaForFIXP.xmlis CC BY-ND 4.0 and must never ship in the MITironfix-fixpcrate. It is already excluded from the package; this PR makes CI enforce that, and writes down the rule for the schema.Changes
New
make check-package-fixptarget:cargo package -p ironfix-fixp --list;spec/, anSBEschemafile orLICENSE-FIXPwould be published.lint.ymlruns the new target.ironfix-fixp/spec/README.md(new "Rules for this directory" section) and the crate docs state the rule:The codec stays hand-written.
The local agent rules (
CLAUDE.md, which is not committed) carry the same rule, so the committed crate docs andspec/README.mdare the repository record.Testing
make check-package-fixppasses on this branch."spec"removed fromexcludeinironfix-fixp/Cargo.toml(not committed), the target fails and listsspec/LICENSE-FIXP,spec/README.mdandspec/SBEschemaForFIXP.xml.cargo clippy -p ironfix-fixp --all-targets -D warnings,RUSTDOCFLAGS=-D warnings cargo doc -p ironfix-fixp,make check-spanishandcargo test -p ironfix-fixp(176 + 2 + 11) all clean.No API change.
Closes #203