You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Honestly, I'm not super familiar with what's recommended in Jsonnet environments.
I have to admit that generally speaking, I don't like vendoring, especially when the programming environment is mature enough. But, I decided to keep the vendor in this case because I have seen large Jsonnet projects using vendoring, where not used for other environments/programming languages, so I guess that it's perhaps a good practice there.
That being said; I'd probably be happy to remove vendor from this example, as it is just an example, and it's correct working is non-critical. But, to do so, shouldn't we update the GitHub Workflow to download the dependencies at deploy time? If so, could you also please update the README.md, and resolve the conflicts accordingly?
If you're too busy, don't worry. I may re-evaluate this in the future. So far I'm already super happy that you already contributed to make the example better 💟
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the grafonnet dependency to latest and removing
vendorfrom git history.