fix: Don't add user to group when deleting it - #94
Merged
Conversation
CarlSchwan
force-pushed
the
carl/fix-adding-remoed-user
branch
from
August 4, 2026 09:24
9d916be to
0e38da3
Compare
CarlSchwan
marked this pull request as draft
August 4, 2026 09:26
CarlSchwan
force-pushed
the
carl/fix-adding-remoed-user
branch
2 times, most recently
from
August 4, 2026 09:40
9178a16 to
efbbabd
Compare
CarlSchwan
marked this pull request as ready for review
August 4, 2026 09:40
CarlSchwan
force-pushed
the
carl/fix-adding-remoed-user
branch
from
August 4, 2026 09:41
efbbabd to
ad6db99
Compare
7 tasks
CarlSchwan
force-pushed
the
carl/fix-adding-remoed-user
branch
from
August 4, 2026 09:50
ad6db99 to
5f20246
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/fix-adding-remoed-user
branch
from
August 4, 2026 10:02
5f20246 to
f5b4a42
Compare
Contributor
Author
|
Thanks for merging :) If you could do a new minor release with this patch I would make me very happy :) |
Owner
|
Sure, many thanks for your improvements! What about #95 , will it land soon as well (so we should include it), or should I go ahead already? |
Contributor
Author
|
We can go ahead already. I'll do some more cleanup and finish #95 when I have time :) |
Owner
|
Release 1.7.2 is published now. 馃槂 Thanks a lot for your contributions again. If you'd consider leaving a positive rating in the Nextcloud App Store, that would be nice. 馃槈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: I am investigating a bug where a user get deleted via OC\User\BackgroundJobs\CleanupDeletedUsers and first we remove the user from every groups before deleting it. But when it is getting deleted, it is getting readded to a group by this app which trigger another signal to the DefaultShareProvider to add it to a share which fails hard as the user is deleted and is no longer found.