perf: use getUserGroupIds - #92
Merged
Merged
Conversation
Contributor
Author
|
Need to adapt the unit tests :( But generally I don't get that code it's discarding the full group object with the array_key and then load the group again with $this->groupManager->search Edit: Ah $userGroupNames and $groupNames are not the same xD |
Several time faster than getUserGroups as we don't have to load group objects. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/perf-getUserGroupIds
branch
from
August 4, 2026 09:19
f0b10eb to
c961f07
Compare
Owner
|
Also thansk for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several time faster than getUserGroups as we don't have to load group objects.