Skip to content

Enforce max_frames in TLVParser and LegacyParser#16

Merged
jmestwa-coder merged 2 commits into
jmestwa-coder:mainfrom
Chayashree-BR:fix-max-frames
May 27, 2026
Merged

Enforce max_frames in TLVParser and LegacyParser#16
jmestwa-coder merged 2 commits into
jmestwa-coder:mainfrom
Chayashree-BR:fix-max-frames

Conversation

@Chayashree-BR

Copy link
Copy Markdown
Contributor

Summary

Enforces max_frames limit in TLVParser and LegacyParser to prevent excessive frame parsing and improve safety. Ensures consistent behavior across modern and legacy parsing paths.

Type of Change

  • Parser or protocol handling
  • Validation or diagnostics
  • Storage, cache, transport, or worker behavior
  • Documentation or tooling
  • Test-only change

Checklist

  • The change is narrowly scoped.
  • Regression tests or fixtures were added for parser/validation fixes.
  • Legacy stream behavior is preserved or documented.
  • Documentation was updated when public behavior changed.
  • pytest and ruff check sigflow tests were run locally when applicable.

@jmestwa-coder jmestwa-coder linked an issue May 26, 2026 that may be closed by this pull request
@jmestwa-coder jmestwa-coder removed a link to an issue May 26, 2026
@jmestwa-coder

Copy link
Copy Markdown
Owner

@Chayashree-BR

resolve the conflicts

@jmestwa-coder

Copy link
Copy Markdown
Owner

@Chayashree-BR
LGTM.
Before merge, please add regression tests covering:

  • TLVParser stopping at max_frames,
  • LegacyParser stopping at max_frames,
  • and ensuring the diagnostic warning is emitted consistently.

Also please add the missing trailing newline to the modified files to match repository formatting conventions.

Please squash the changes into a single commit before submission/update.

Resolve TLV merge conflict

Add regression tests for max_frames handling
@jmestwa-coder

Copy link
Copy Markdown
Owner

@Chayashree-BR, there are conflicts. resolve it

@jmestwa-coder

Copy link
Copy Markdown
Owner

@Chayashree-BR
LGTM. Merging.

@jmestwa-coder jmestwa-coder merged commit fbc7191 into jmestwa-coder:main May 27, 2026
3 checks passed
@jmestwa-coder

Copy link
Copy Markdown
Owner

@Chayashree-BR, Thank you for your contribution.

The submitted fix has been reviewed and merged successfully. You have successfully completed this evaluation task and have been shortlisted for the next round of the selection process.

Please send the following details to shortlist@digiscrypt.com for verification purposes:

Pull Request link
Merged commit link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLVParser does not enforce max_frames limit inherited from BaseParser

2 participants