Improve error message when running git-sweep in non-repository directory#8
Draft
Improve error message when running git-sweep in non-repository directory#8
Conversation
Author
|
@jmelosegui 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: jmelosegui <450246+jmelosegui@users.noreply.github.com>
…irectory Co-authored-by: jmelosegui <450246+jmelosegui@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve message when running the sweep in a non repo directory
Improve error message when running git-sweep in non-repository directory
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
git-sweepis run in a directory that is not a git repository, it previously showed a technical error message that was not user-friendly:This change improves the error handling to detect when the underlying git command fails because we're not in a git repository, and returns the same clear message that Git itself provides:
The fix is minimal and surgical - it only modifies the
IsInsideWorkTreefunction ininternal/git/helpers.goto detect the "not a git repository" error in stderr and return an appropriate user-friendly message. All existing functionality remains unchanged, and the tool continues to work normally when run in actual git repositories.Before:
After:
$ cd /tmp $ git-sweep error: fatal: not a git repository (or any of the parent directories): .gitFixes #7.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.