Fix local API service auth file for access-token-only bindings#994
Open
luoyanglang wants to merge 1 commit into
Open
Fix local API service auth file for access-token-only bindings#994luoyanglang wants to merge 1 commit into
luoyanglang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id_tokenid_tokenRoot Cause
Access-token-only OAuth imports can have an empty
id_token. When the local API service runtime API-key account was bound to one of those OAuth accounts, the shared bundle writer wrote an OAuth-shapedauth.jsonfirst and then applied the local provider override.That could leave the takeover profile with
OPENAI_API_KEY: nullandtokens.id_token: "", which the client rejects as an invalid ID token.Validation
cargo fmt -p cockpit-toolscargo test -p cockpit-tools --lib api_key_bundle_bound -- --nocapturecargo test -p cockpit-tools --lib build_auth_file_value -- --nocapturecargo test -p cockpit-tools --lib api_key_config_toml -- --nocapturecargo test -p cockpit-tools --lib codex_account -- --nocapturecargo test -p cockpit-tools --lib local_access_profile -- --nocapturecargo check -p cockpit-toolsnpm run typecheckNo user-facing configuration changed, so no public docs were updated.
Related