Repository navigation
Accept the GLMM snapshot for lme4 2.1-0 - #143
Merged
Merged
Conversation
lme4 2.1-0 refreshes the PIRLS weights before the Laplace approximation, which moves this fit slightly: deviance 73.4743 to 73.4715, in 238 optimizer evaluations rather than 285. In one Linux container, 2.0-1 and 2.0-6 reproduce the old snapshot and 2.1-0 the new one, so merTools itself did not change. The test now skips on an older lme4. Closes #142 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R-CMD-check has failed on Ubuntu since lme4 2.1-0, on the
GLMM binomialsnapshot. macOSand Windows skip that test.
fitThose three runs share one Linux container and the same merTools source, so lme4 is the
only thing that changed. The fit is slightly better. lme4's NEWS for 2.1-0 says
glmer()now refreshes the working weights at the accepted PIRLS mean before the Laplace
approximation.
This accepts the new values, in the GLMM section only, and skips that test on an older
lme4, so nobody on 2.0-x gets a false failure. The
lmersnapshots did not move.Closes #142
Test plan
🤖 Generated with Claude Code