Skip to content

Added shortcode support#2

Open
ehrphil wants to merge 1 commit into
jkeyes:masterfrom
ehrphil:master
Open

Added shortcode support#2
ehrphil wants to merge 1 commit into
jkeyes:masterfrom
ehrphil:master

Conversation

@ehrphil

@ehrphil ehrphil commented Jan 8, 2018

Copy link
Copy Markdown

Added shortcode option [revisions] for more flexible use in templates.

Added shortcode option [revisions] for more flexible use in templates.
@jkeyes

jkeyes commented Jan 8, 2018

Copy link
Copy Markdown
Owner

Hi @ehrphil, there's a lot of changes in this PR. As you are aware I've not been very actively looking after this plugin 😉 I'll need to refamiliarise myself with it all. Thanks for the contribution.

@ehrphil

ehrphil commented Jan 8, 2018 via email

Copy link
Copy Markdown
Author

@jkeyes

jkeyes commented Jan 9, 2018

Copy link
Copy Markdown
Owner

@ehrphil I've noticed the links to the "previous" versions are not working in the WordPress 4.9.1 – have you seen similar? Whenever I click on a link I see the latest content. I fixed this locally last night.

Also noticed that WordPress now returns the current revision in the list of revisions for the post, which means we end up with two entries in the Revision History for the most recent entry. I've test a local fix for this too. Have you seen this happening either?

I think what I'll do is:

  • copy the latest version of the plugin that's released 0.9.1 into this repository (I don't know why it's not already in here)
  • test with that 0.9.1 against WordPress 4.9.1 and confirm my findings above
  • fix the revision link issue
  • fix the duplicate revision entry in the list
  • test against WordPress 4.9.1

Then you could test that version to make sure it's behaving as expected. When we have that all sorted, we can then reapply your shortcode work, and release it as version 1.0. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants